-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eff + Cond Lidded #7094
base: dev/feature
Are you sure you want to change the base?
Eff + Cond Lidded #7094
Conversation
I think this should be an effect/condition rather than an expression that can only be true or false |
I'm in agreement with cheeze as paper has a new pr about a week ago aiming to add new lidded states not yet merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this should be an effect and condition rather than an expression, but here's some things I noticed anyway.
agreed |
Kept the changes that suited best between the overlapping requested changes
Description
This PR aims to add setting the open/close animation of lidded blocks (chests, enderchests, barrels, and shulker boxes)
Target Minecraft Versions: any
Requirements: none
Related Issues: #5715